Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return structured ColumnCloseResult (#2465) #2466

Merged
merged 3 commits into from Aug 18, 2022

Conversation

tustvold
Copy link
Contributor

Which issue does this PR close?

Closes #2465

Rationale for this change

This has been a pet-peeve of mine for a while, but thought I would finally fix it

What changes are included in this PR?

Are there any user-facing changes?

Yes, this changes the return type of ColumnWriter::close. In most cases users won't be interacting with the return type directly, as they'll be using SerializedColumnWriter or similar, and so I think this is ok

@tustvold tustvold added the api-change Changes to the arrow API label Aug 16, 2022
@github-actions github-actions bot added the parquet Changes to the parquet crate label Aug 16, 2022
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a nice improvement to me

Option<ColumnIndex>,
Option<OffsetIndex>,
);
/// Metadata returned by [`GenericColumnWriter::close`]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is much nicer documentation 👍

@tustvold tustvold merged commit 4459a0e into apache:master Aug 18, 2022
@ursabot
Copy link

ursabot commented Aug 18, 2022

Benchmark runs are scheduled for baseline = 79d31a9 and contender = 4459a0e. 4459a0e is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@alamb alamb changed the title Return structured ColumnCloseResult (#2465) Return structured ColumnCloseResult (#2465) Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-change Changes to the arrow API parquet Changes to the parquet crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Return Structured ColumnCloseResult from GenericColumnWriter::close
3 participants