Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utf8array casting #2456

Merged
merged 4 commits into from Aug 16, 2022
Merged

Utf8array casting #2456

merged 4 commits into from Aug 16, 2022

Conversation

psvri
Copy link
Contributor

@psvri psvri commented Aug 15, 2022

Which issue does this PR close?

Closes #2402.

Rationale for this change

Implement casting of utf8[large] to binary[large] in kernels::cast

What changes are included in this PR?

  • Added support for utf8[large] to binary[large] in kernels::cast
  • removed deprecated expressions like std::< numeric >::(MAX|MIN) in kernels::cast::test module
  • fixed typo in doc comment of datatypes::is_numeric

Are there any user-facing changes?

None

@github-actions github-actions bot added the arrow Changes to the arrow crate label Aug 15, 2022
array
.iter()
.map(|x| x.map(|data| data.as_bytes()))
.collect::<GenericBinaryArray<OffsetSize>>(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this isn't changing the size of the offsets, it would be significantly faster to just reuse the existing buffers

Something like

assert_eq(array.data_type(), DataType::Utf8);
array.data().clone().into_builder().data_type(DataType::Binary).build_unchecked()

And similar for LargeUtf8 and LargeBinary

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed it in latest commit

Copy link
Contributor

@tustvold tustvold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍

@tustvold tustvold merged commit 6a1b9ee into apache:master Aug 16, 2022
@ursabot
Copy link

ursabot commented Aug 16, 2022

Benchmark runs are scheduled for baseline = 7a74465 and contender = 6a1b9ee. 6a1b9ee is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@Dandandan
Copy link
Contributor

Thanks @psvri !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support casting from Utf8/LargeUtf8 to Binary/LargeBinary
4 participants