Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DoPutUpdateResult #2404

Merged

Conversation

avantgardnerio
Copy link
Contributor

Which issue does this PR close?

Closes #2403.

Rationale for this change

My company would like to have JDBC/ODBC support work so that we can develop a market offering on top of Ballista.

What changes are included in this PR?

Update the responses to follow the spec and be compatible with the JDBC implementation.

Are there any user-facing changes?

Queries shouldn't hang forever.

@github-actions github-actions bot added the arrow-flight Changes to the arrow-flight crate label Aug 10, 2022
Copy link
Contributor

@tustvold tustvold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if there are any other erroneous uses of as_any in this file?

@andygrove
Copy link
Member

@wangfenjin fyi

@andygrove
Copy link
Member

It would be nice if we could eventually add some tests for this

@tustvold tustvold merged commit c275c5e into apache:master Aug 11, 2022
@ursabot
Copy link

ursabot commented Aug 11, 2022

Benchmark runs are scheduled for baseline = 27f4762 and contender = c275c5e. c275c5e is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@tustvold
Copy link
Contributor

I created a high-level ticket for some form of integration testing - #2409

I've left it fairly brief as I'm probably not the right person to flesh it out, as my knowledge of FlightSQL is pretty limited, but I agree it would be a good thing to have

@avantgardnerio
Copy link
Contributor Author

some form of integration testing

100%. I think this is the right way to go. I can probably take that one on. I'm experienced with it, and I think it's the type of testing that will catch problems like this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow-flight Changes to the arrow-flight crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flight SQL Server sends incorrect response for DoPutUpdateResult
4 participants