Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated SliceableCursor and InMemoryWriteableCursor #2378

Merged
merged 1 commit into from Aug 8, 2022
Merged

Remove deprecated SliceableCursor and InMemoryWriteableCursor #2378

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
19 changes: 1 addition & 18 deletions parquet/src/file/serialized_reader.rs
View file
Open in desktop
Expand Up @@ -39,8 +39,7 @@ use crate::util::{io::TryClone, memory::ByteBufferPtr};

// export `SliceableCursor` and `FileSource` publically so clients can
// re-use the logic in their own ParquetFileWriter wrappers
#[allow(deprecated)]
pub use crate::util::{cursor::SliceableCursor, io::FileSource};
pub use crate::util::io::FileSource;

// ----------------------------------------------------------------------
// Implementations of traits facilitating the creation of a new reader
Expand Down Expand Up @@ -86,22 +85,6 @@ impl ChunkReader for Bytes {
}
}

#[allow(deprecated)]
impl Length for SliceableCursor {
fn len(&self) -> u64 {
SliceableCursor::len(self)
}
}

#[allow(deprecated)]
impl ChunkReader for SliceableCursor {
type T = SliceableCursor;

fn get_read(&self, start: u64, length: usize) -> Result<Self::T> {
self.slice(start, length).map_err(|e| e.into())
}
}

impl TryFrom<File> for SerializedFileReader<File> {
type Error = ParquetError;

Expand Down
284 changes: 0 additions & 284 deletions parquet/src/util/cursor.rs
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion parquet/src/util/mod.rs
View file
Open in desktop
Expand Up @@ -20,7 +20,6 @@ pub mod memory;
#[macro_use]
pub mod bit_util;
mod bit_pack;
pub mod cursor;
pub(crate) mod interner;
pub(crate) mod page_util;
#[cfg(any(test, feature = "test_common"))]
Expand Down