Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add API to change timezone for timestamp array #2347

Merged
merged 3 commits into from Aug 7, 2022
Merged

Add API to change timezone for timestamp array #2347

merged 3 commits into from Aug 7, 2022

Conversation

viirya
Copy link
Member

@viirya viirya commented Aug 7, 2022

Which issue does this PR close?

Closes #2346.

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added the arrow Changes to the arrow crate label Aug 7, 2022
tustvold
tustvold reviewed Aug 7, 2022
View reviewed changes
arrow/src/array/array_primitive.rs Outdated

/// Construct a timestamp array with new timezone
pub fn with_timezone(&self, timezone: String) -> Self {
let array_data =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be more concise and less error prone to use the into_builder functionality. Something like self.data().clone().into_builder()

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice.

@viirya viirya merged commit 5fae299 into apache:master Aug 7, 2022
@ursabot
Copy link

ursabot commented Aug 7, 2022

Benchmark runs are scheduled for baseline = a2de363 and contender = 5fae299. 5fae299 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@tustvold tustvold mentioned this pull request Oct 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tustvold tustvold tustvold approved these changes

Assignees
No one assigned
Labels
arrow Changes to the arrow crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add API to change timezone for timestamp array
3 participants
@viirya @ursabot @tustvold