Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Minor] Misc cleanup docs and uneeded test `use #2330

Merged
merged 1 commit into from Aug 5, 2022
Merged

[Minor] Misc cleanup docs and uneeded test `use #2330

merged 1 commit into from Aug 5, 2022

Conversation

tustvold
Copy link
Contributor

@tustvold tustvold commented Aug 5, 2022

Which issue does this PR close?

Closes #.

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@tustvold tustvold added the development-process Related to development process of arrow-rs label Aug 5, 2022
@github-actions github-actions bot added arrow Changes to the arrow crate parquet Changes to the parquet crate labels Aug 5, 2022
alamb
alamb reviewed Aug 5, 2022
View reviewed changes
arrow/README.md
@@ -117,7 +117,7 @@ it relies heavily on LLVM auto-vectorisation to achieve this. Unfortunately the
particularly for x86_64, favour portability over performance, and LLVM will consequently avoid
using more recent instructions that would result in errors on older CPUs.

To address this it is recommended that you specify the override the LLVM defaults either
To address this it is recommended that you override the LLVM defaults either
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ref: https://github.com/apache/arrow-rs/pull/2324/files#r938584363

@alamb alamb changed the title Misc cleanup [Minor] Misc cleanup docs and uneeded test `use Aug 5, 2022
@tustvold tustvold merged commit 6859efa into apache:master Aug 5, 2022
@ursabot
Copy link

ursabot commented Aug 5, 2022

Benchmark runs are scheduled for baseline = 4a3919b and contender = 6859efa. 6859efa is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb approved these changes

Assignees
No one assigned
Labels
arrow Changes to the arrow crate development-process Related to development process of arrow-rs parquet Changes to the parquet crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tustvold @ursabot @alamb