Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move with_precision_and_scale to BasicDecimalArray trait #2292

Merged
merged 1 commit into from Aug 3, 2022
Merged

Move with_precision_and_scale to BasicDecimalArray trait #2292

merged 1 commit into from Aug 3, 2022

Conversation

viirya
Copy link
Member

@viirya viirya commented Aug 3, 2022

Which issue does this PR close?

Closes #2291.

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added arrow Changes to the arrow crate parquet Changes to the parquet crate labels Aug 3, 2022
@alamb alamb changed the title Move with_precision_and_scale to Decimal array trait Move with_precision_and_scale to Decimal array trait Aug 3, 2022
@alamb alamb changed the title Move with_precision_and_scale to Decimal array trait Move with_precision_and_scale to BasicDecimalArray trait Aug 3, 2022
alamb
alamb approved these changes Aug 3, 2022
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks great 🚀

@viirya viirya merged commit e835853 into apache:master Aug 3, 2022
@viirya
Copy link
Member Author

viirya commented Aug 3, 2022

Thanks @alamb

@ursabot
Copy link

ursabot commented Aug 3, 2022

Benchmark runs are scheduled for baseline = f40403f and contender = e835853. e835853 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb approved these changes

Assignees
No one assigned
Labels
arrow Changes to the arrow crate parquet Changes to the parquet crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move with_precision_and_scale to Decimal array traits
3 participants
@viirya @ursabot @alamb