Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase test coverage of ArrowWriter #2220

Merged
merged 1 commit into from Jul 29, 2022

Conversation

tustvold
Copy link
Contributor

Which issue does this PR close?

Part of #1764

Rationale for this change

Whilst working on #1764 I realised we didn't have very good test coverage of writing arrow arrays with different encodings to parquet. This is because the arrow_reader fuzz tests write data using the ColumnWriter API and not the arrow writer API.

In the past these have boiled down to much the same thing, and so this hasn't been an issue. However, as we move to writing directly from arrow arrays, we introduce new codepaths that need testing

What changes are included in this PR?

Ensures good coverage of various encodings, writer versions, etc...

Are there any user-facing changes?

No, this just changes some tests

@github-actions github-actions bot added the parquet Changes to the parquet crate label Jul 29, 2022
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 for adding tests first before changing code 👍

For any other reviewer, I found https://github.com/apache/arrow-rs/pull/2220/files?w=1 without whitespace easier to review

@tustvold tustvold merged commit 3505afa into apache:master Jul 29, 2022
@ursabot
Copy link

ursabot commented Jul 29, 2022

Benchmark runs are scheduled for baseline = 6ce4c4e and contender = 3505afa. 3505afa is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parquet Changes to the parquet crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants