Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Hash for Schema #2183

Merged
merged 1 commit into from Jul 28, 2022
Merged

Conversation

crepererum
Copy link
Contributor

Which issue does this PR close?

Closes #2182.

Rationale for this change

Hash is sometimes helpful, see #2182 for some examples.

What changes are included in this PR?

Implements Hash for Schema.

Are there any user-facing changes?

New trait implementation, not a breaking change.

@github-actions github-actions bot added the arrow Changes to the arrow crate label Jul 27, 2022
Copy link
Contributor

@tustvold tustvold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine, although I do wonder if we need some way to highlight that this is a relatively expensive computation...

@crepererum
Copy link
Contributor Author

I think this is fine, although I do wonder if we need some way to highlight that this is a relatively expensive computation...

The "expensiveness" was more concerned regarding the usage. I think a user should judge how expensive Eq/Hash on complex/container-like data structures are. You can easily Eq/Hash BTreeSet<BTreeMap<String, Vec<String>>> but sure, it's expensive. Same goes for a Schema, esp. if you attach LOADS for metadata.

However we could add a doc comment somewhere.

@tustvold tustvold merged commit 6c77cd5 into apache:master Jul 28, 2022
@ursabot
Copy link

ursabot commented Jul 28, 2022

Benchmark runs are scheduled for baseline = b8e034c and contender = 6c77cd5. 6c77cd5 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Hash for Schema
3 participants