New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lazily materialize the null buffer builder for all array builders. #2127
Merged
tustvold
merged 25 commits into
apache:master
from
HaoYang670:lazily_materialize_null_buffer_builder
Jul 26, 2022
Merged
Changes from 15 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
3354e33
create null buffer builder
HaoYang670 118417d
use null buffer builder in boolean array builder
HaoYang670 6f13da6
add capacity field and update docs
HaoYang670 6b83eb1
update fixed size binary builder
HaoYang670 22b6a33
update fixed size list builder
HaoYang670 5c78441
update binary builder
HaoYang670 98cd443
update list builder
HaoYang670 092cb30
update map builder
HaoYang670 caa4c13
update struct builder
HaoYang670 a54d2f6
update union builder
HaoYang670 bd2e642
rename
HaoYang670 b473be3
add tests
HaoYang670 1674093
optimize
HaoYang670 04c43cc
expose null buffer builder in builder mod
HaoYang670 dd49d30
add docs
HaoYang670 9b6d984
reduce redundant computation
HaoYang670 0c0031f
inline methods to achieve better performance
HaoYang670 b09081f
use instead of pub(self) use
HaoYang670 584aa22
merge master
HaoYang670 1444d7b
Update arrow/src/array/builder/null_buffer_builder.rs
HaoYang670 f15c088
Merge branch 'master' into lazily_materialize_null_buffer_builder
HaoYang670 c073b32
reorder
HaoYang670 28be7d8
Merge branch 'master' into lazily_materialize_null_buffer_builder
HaoYang670 0895a80
Merge branch 'lazily_materialize_null_buffer_builder' of https://gith…
HaoYang670 49c963c
rename methods and update docs
HaoYang670 File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a simple doc?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added!