Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define Decimal128Builder and Decimal128Array #2102

Merged
merged 1 commit into from Jul 19, 2022

Conversation

viirya
Copy link
Member

@viirya viirya commented Jul 18, 2022

Which issue does this PR close?

Closes #2101.

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added arrow Changes to the arrow crate parquet Changes to the parquet crate labels Jul 18, 2022
@viirya viirya force-pushed the decimal128array branch 2 times, most recently from 2a4fb3c to 00d66c8 Compare July 18, 2022 20:35
Copy link
Contributor

@HaoYang670 HaoYang670 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pub use self::array_decimal::Decimal256Array;
pub use self::array_decimal::DecimalArray;

#[deprecated(note = "Please use `Decimal128Array` instead")]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@viirya viirya merged commit efd3152 into apache:master Jul 19, 2022
@viirya
Copy link
Member Author

viirya commented Jul 19, 2022

Thanks @liukun4515 @HaoYang670

@ursabot
Copy link

ursabot commented Jul 19, 2022

Benchmark runs are scheduled for baseline = 2541e2c and contender = efd3152. efd3152 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate parquet Changes to the parquet crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename DecimalArray/DecimalBuilder to Decimal128Array/Decimal128Builder
4 participants