Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove preserve_order feature from serde_json dependency (#2095) #2098

Merged
merged 2 commits into from Jul 18, 2022
Merged

Remove preserve_order feature from serde_json dependency (#2095) #2098

merged 2 commits into from Jul 18, 2022

Conversation

tustvold
Copy link
Contributor

Which issue does this PR close?

Closes #2095

Rationale for this change

See #2095 and #1882

What changes are included in this PR?

Disables the serde_json, preserve_order feature

Are there any user-facing changes?

Potentially, although as noted by @nevi-me #1882 (comment) it would likely be incorrect for a user to be relying on this behaviour anyway.

@tustvold tustvold added the api-change Changes to the arrow API label Jul 18, 2022
@github-actions github-actions bot added arrow Changes to the arrow crate parquet Changes to the parquet crate labels Jul 18, 2022
@tustvold tustvold marked this pull request as draft July 18, 2022 17:34
@tustvold tustvold marked this pull request as ready for review July 18, 2022 19:54
@alamb
Copy link
Contributor

alamb commented Jul 18, 2022

Can we remove indexmap while we are at it?

@alamb
Copy link
Contributor

alamb commented Jul 18, 2022

Also, can we make the test change suggested by @nevi-me in #1882 (comment) ?

@tustvold
Copy link
Contributor Author

I think I would rather keep this change smaller, and we can remove indexmap, etc... as a follow up?

alamb
alamb approved these changes Jul 18, 2022
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do it . Thanks @tustvold

@tustvold tustvold merged commit 2541e2c into apache:master Jul 18, 2022
@ursabot
Copy link

ursabot commented Jul 18, 2022

Benchmark runs are scheduled for baseline = 619be77 and contender = 2541e2c. 2541e2c is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@alamb alamb changed the title Remove preserve_order feature from serde_json (#2095) Remove preserve_order feature from serde_json dependency (#2095) Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb approved these changes

Assignees
No one assigned
Labels
api-change Changes to the arrow API arrow Changes to the arrow crate parquet Changes to the parquet crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Why does serde_json specify the preserve_order feature in arrow package
3 participants
@tustvold @alamb @ursabot