Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set DICTIONARY_ORDERED flag for FFI_ArrowSchema #2050

Merged
merged 2 commits into from Jul 12, 2022

Conversation

viirya
Copy link
Member

@viirya viirya commented Jul 12, 2022

Which issue does this PR close?

Closes #2049.

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added the arrow Changes to the arrow crate label Jul 12, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #2050 (af72eeb) into master (742a590) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2050   +/-   ##
=======================================
  Coverage   83.55%   83.56%           
=======================================
  Files         222      222           
  Lines       58216    58226   +10     
=======================================
+ Hits        48645    48656   +11     
+ Misses       9571     9570    -1     
Impacted Files Coverage Δ
arrow/src/datatypes/ffi.rs 76.56% <100.00%> (+1.56%) ⬆️
arrow/src/ffi.rs 87.52% <100.00%> (+0.04%) ⬆️
...row/src/array/builder/string_dictionary_builder.rs 90.64% <0.00%> (-0.72%) ⬇️
parquet/src/encodings/encoding.rs 93.43% <0.00%> (-0.20%) ⬇️
parquet_derive/src/parquet_field.rs 65.98% <0.00%> (+0.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 742a590...af72eeb. Read the comment docs.

@viirya viirya merged commit a2f223c into apache:master Jul 12, 2022
@viirya
Copy link
Member Author

viirya commented Jul 12, 2022

Thanks @tustvold

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FFI_ArrowSchema should set DICTIONARY_ORDERED flag if a field's dictionary is ordered
3 participants