Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more tests of RecordReader Batch Size Edge Cases (#2025) #2032

Merged
merged 2 commits into from Jul 15, 2022

Conversation

tustvold
Copy link
Contributor

@tustvold tustvold commented Jul 8, 2022

Follow on from #2027, this just tests a few more edge cases

@github-actions github-actions bot added the parquet Changes to the parquet crate label Jul 8, 2022
@tustvold tustvold changed the title Add more tests of #2025 Add more tests of RecordReader Batch Size Edge Cases (#2025) Jul 8, 2022
parquet/src/arrow/arrow_reader.rs Show resolved Hide resolved
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
@codecov-commenter
Copy link

Codecov Report

Merging #2032 (d2ce4b6) into master (5a76697) will increase coverage by 0.13%.
The diff coverage is 92.88%.

❗ Current head d2ce4b6 differs from pull request most recent head 4c793ea. Consider uploading reports for the commit 4c793ea to get more accurate results

@@            Coverage Diff             @@
##           master    #2032      +/-   ##
==========================================
+ Coverage   83.55%   83.68%   +0.13%     
==========================================
  Files         222      224       +2     
  Lines       58230    58833     +603     
==========================================
+ Hits        48654    49236     +582     
- Misses       9576     9597      +21     
Impacted Files Coverage Δ
arrow/src/array/builder/primitive_builder.rs 92.57% <ø> (-0.55%) ⬇️
arrow/src/array/mod.rs 100.00% <ø> (ø)
arrow/src/datatypes/mod.rs 99.24% <ø> (ø)
parquet/src/arrow/async_reader.rs 0.00% <0.00%> (ø)
parquet/src/arrow/record_reader/mod.rs 89.17% <ø> (ø)
parquet/src/column/page.rs 98.68% <ø> (ø)
parquet/src/util/test_common/page_util.rs 86.73% <0.00%> (ø)
arrow/src/datatypes/datatype.rs 64.41% <30.00%> (-1.27%) ⬇️
parquet/src/file/metadata.rs 94.70% <66.66%> (-0.69%) ⬇️
arrow/src/ffi.rs 87.52% <72.72%> (+0.34%) ⬆️
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a76697...4c793ea. Read the comment docs.

@tustvold tustvold merged commit a7181dd into apache:master Jul 15, 2022
@ursabot
Copy link

ursabot commented Jul 15, 2022

Benchmark runs are scheduled for baseline = cb7e5b0 and contender = a7181dd. a7181dd is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parquet Changes to the parquet crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants