Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support DictionaryArray in add_scalar kernel #2018

Merged
merged 3 commits into from Jul 7, 2022

Conversation

viirya
Copy link
Member

@viirya viirya commented Jul 6, 2022

Which issue does this PR close?

Closes #2017.

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added the arrow Changes to the arrow crate label Jul 6, 2022
@viirya
Copy link
Member Author

viirya commented Jul 6, 2022

cc @sunchao

Copy link
Member

@sunchao sunchao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Merging #2018 (a4e99e8) into master (62053a8) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2018      +/-   ##
==========================================
+ Coverage   83.58%   83.59%   +0.01%     
==========================================
  Files         222      222              
  Lines       57639    57669      +30     
==========================================
+ Hits        48180    48211      +31     
+ Misses       9459     9458       -1     
Impacted Files Coverage Δ
arrow/src/compute/kernels/arithmetic.rs 92.35% <100.00%> (+0.40%) ⬆️
parquet_derive/src/parquet_field.rs 66.21% <0.00%> (+0.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62053a8...a4e99e8. Read the comment docs.

@viirya viirya merged commit f8fa984 into apache:master Jul 7, 2022
@viirya
Copy link
Member Author

viirya commented Jul 7, 2022

Thanks @sunchao

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support DictionaryArray in add_scalar kernel
3 participants