Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine the FixedSizeBinaryBuilder #2013

Merged
merged 3 commits into from Jul 6, 2022

Conversation

HaoYang670
Copy link
Contributor

Which issue does this PR close?

Closes #2007.

Rationale for this change

Build FixedSizeBInaryArray in a more simple way.

What changes are included in this PR?

  1. Change the struct of FixedSizeBinaryBuilder
  2. Refine some code and docs
  3. Add more tests.

Are there any user-facing changes?

No,

Signed-off-by: remzi <13716567376yh@gmail.com>
Signed-off-by: remzi <13716567376yh@gmail.com>
@github-actions github-actions bot added the arrow Changes to the arrow crate label Jul 6, 2022
Signed-off-by: remzi <13716567376yh@gmail.com>
Copy link
Contributor

@tustvold tustvold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you 👍

@tustvold tustvold merged commit b156cce into apache:master Jul 6, 2022
@HaoYang670 HaoYang670 deleted the refine_fixedsizebinarybuilder branch July 7, 2022 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simplify FixedSizeBinaryBuilder
2 participants