Add page index reader test and support empty index. #2011
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
arrow-flight
Ted-Jiang
commented
Jul 6, 2022
| //col6->bigint_col: INT64 UNCOMPRESSED DO:0 FPO:152326 SZ:71598/71598/1.00 VC:7300 ENC:BIT_PACKED,RLE,PLAIN ST:[min: 0, max: 90, num_nulls: 0] | ||
| if let Index::INT64(index) = &page_indexes[0][5] { | ||
| //Todo row_group_metadata.column(0).statistics().unwrap().min_bytes() only return 4 bytes | ||
| check_native_page_index( |
There was a problem hiding this comment.
i try to use
row_group_metadata
.column(0)
.statistics()
.unwrap()
.min_bytes(),
get min values from one column chunk metadata in type In64, but it return only 4 bytes...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #2010.
Rationale for this change
After apache/parquet-testing#25 merged, there will be standard page index test file in parquet-testing.All types support page index in parquet-format has add test in this pr.
Another change:
I found there is a situation one col has
pageLocationbut without min_max index(馃槀 i missed it). So addEMPTY_ARRAYin enumIndex.What changes are included in this PR?
Are there any user-facing changes?