New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unary_cmp #1991
Add unary_cmp #1991
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1991 +/- ##
=======================================
Coverage 83.57% 83.57%
=======================================
Files 221 222 +1
Lines 57482 57550 +68
=======================================
+ Hits 48043 48100 +57
- Misses 9439 9450 +11
Continue to review full report at Codecov.
|
Unrelated error:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps we could inline the macro in unary_op and make the other functions use it 🤔. Less macros is always good imo
I just tried it. However, |
return compare_op_scalar!(left, |a| a == right); | ||
} | ||
|
||
/// Applies an unary and infallible comparison function to a primitive array. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️ thank you @viirya
Which issue does this PR close?
Closes #1987.
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?