Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support dictionary array for subtract and multiply kernel #1971

Merged
merged 2 commits into from Jun 30, 2022
Merged

Support dictionary array for subtract and multiply kernel #1971

merged 2 commits into from Jun 30, 2022

Conversation

viirya
Copy link
Member

@viirya viirya commented Jun 30, 2022 •
edited

Which issue does this PR close?

Closes #1970.
Closes #1972.

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added the arrow Changes to the arrow crate label Jun 30, 2022
@viirya viirya changed the title Support dictionary array for subtract kernel Support dictionary array for subtract and multiply kernel Jun 30, 2022
tustvold
tustvold approved these changes Jun 30, 2022
View reviewed changes
Copy link
Contributor

@tustvold tustvold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@tustvold tustvold merged commit a89c1cf into apache:master Jun 30, 2022
@viirya
Copy link
Member Author

viirya commented Jun 30, 2022

Thanks @tustvold

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tustvold tustvold tustvold approved these changes

Assignees
No one assigned
Labels
arrow Changes to the arrow crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support DictionaryArray in multiply kernel Support DictionaryArray in subtract kernel
2 participants
@viirya @tustvold