Calculate n_buffers in FFI_ArrowArray by data layout #1960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1960 +/- ##
==========================================
+ Coverage 83.47% 83.48% +0.01%
==========================================
Files 221 221
Lines 57054 57117 +63
==========================================
+ Hits 47626 47685 +59
- Misses 9428 9432 +4
Continue to review full report at Codecov.
|
|
cc @sunchao |
viirya
commented
Jun 29, 2022
| @@ -450,7 +450,17 @@ impl FFI_ArrowArray { | |||
| let buffers = iter::once(data.null_buffer().cloned()) | |||
| .chain(data.buffers().iter().map(|b| Some(b.clone()))) | |||
| .collect::<Vec<_>>(); | |||
| let n_buffers = buffers.len() as i64; | |||
| let data_layout = layout(data.data_type()); | |||
| // `n_buffers` is the number of buffers by the spec. | |||
There was a problem hiding this comment.
sunchao
reviewed
Jun 29, 2022
|
Seems unrelated test failure. |
|
Thanks @sunchao |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1959.
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?