Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin clap (#1867) #1954

Merged
merged 1 commit into from Jun 28, 2022
Merged

Unpin clap (#1867) #1954

merged 1 commit into from Jun 28, 2022

Conversation

tustvold
Copy link
Contributor

Which issue does this PR close?

Closes #1867

Rationale for this change

Originally pinned by #1868 to workaround upstream shenanigans. The changes have since been backed out of the upstream - clap-rs/clap#3830 and so we can unpin clap

What changes are included in this PR?

Unpins clap

Are there any user-facing changes?

No

@github-actions github-actions bot added arrow-flight Changes to the arrow-flight crate parquet Changes to the parquet crate labels Jun 28, 2022
@tustvold tustvold removed the arrow-flight Changes to the arrow-flight crate label Jun 28, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1954 (46a6d2e) into master (464e8d1) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1954   +/-   ##
=======================================
  Coverage   83.47%   83.47%           
=======================================
  Files         221      221           
  Lines       57049    57049           
=======================================
+ Hits        47621    47622    +1     
+ Misses       9428     9427    -1     
Impacted Files Coverage Δ
parquet/src/encodings/encoding.rs 93.62% <0.00%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 464e8d1...46a6d2e. Read the comment docs.

@tustvold tustvold merged commit 30e65df into apache:master Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parquet Changes to the parquet crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clap Deprecations
3 participants