Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set is_adjusted_to_utc if any timezone set (#1932) #1953

Merged

Conversation

tustvold
Copy link
Contributor

@tustvold tustvold commented Jun 28, 2022

Which issue does this PR close?

Closes #1932

Rationale for this change

As pointed out by @jorgecarleitao #1937 (comment) we can always set is_adjusted_to_utc if any timezone is set

What changes are included in this PR?

Copies the docstring from arrow schema.fbs into DataType to clarify the potentially unexpected semantics of Timestamp.

Sets is_adjusted_to_utc if any timezone is set

Are there any user-facing changes?

No

@github-actions github-actions bot added arrow Changes to the arrow crate parquet Changes to the parquet crate labels Jun 28, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1953 (21ef83e) into master (464e8d1) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1953   +/-   ##
=======================================
  Coverage   83.47%   83.47%           
=======================================
  Files         221      221           
  Lines       57049    57048    -1     
=======================================
+ Hits        47621    47622    +1     
+ Misses       9428     9426    -2     
Impacted Files Coverage Δ
arrow/src/datatypes/datatype.rs 65.79% <ø> (ø)
parquet/src/arrow/schema.rs 96.87% <100.00%> (-0.01%) ⬇️
parquet/src/arrow/schema/primitive.rs 76.99% <100.00%> (ø)
parquet/src/encodings/encoding.rs 93.62% <0.00%> (+0.19%) ⬆️
parquet_derive/src/parquet_field.rs 65.98% <0.00%> (+0.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 464e8d1...21ef83e. Read the comment docs.

Copy link
Contributor

@nevi-me nevi-me left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The explanation note makes sense

@tustvold tustvold merged commit 420d669 into apache:master Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate parquet Changes to the parquet crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unable to write parquet file with UTC timestamp
3 participants