Require Send+Sync bounds for Allocation trait #1945
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1944.
Rationale for this change
Send + Sync
were previously implemented forBuffer
which probably was not sound in case the underlyingAllocation
was not alsoSend + Sync
.What changes are included in this PR?
Allocation
trait requiresSend + Sync
Bytes
implementsSend + Sync
which should be fine since it only contains aNonNull
pointer in addition to the allocationBuffer
is then automaticallySend + Sync
FFI_ArrowArray
now has to implementSend + Sync
. This requirement was previously hidden by the unsafe impl onBuffer
, even before the introduction of theAllocation
abstraction in Decouple buffer deallocation from ffi and allow creating buffers from rust vec #1494Are there any user-facing changes?
This could be a breaking change for users of the
Allocation
trait, but those usages would have been unsound before.