Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support casting NULL to/from Decimal #1922

Merged
merged 5 commits into from Jun 24, 2022
Merged

Support casting NULL to/from Decimal #1922

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
369b203
support NULL type values to decimal
liukun4515 Jun 22, 2022
5bcfde9
support NULL type values to decimal
liukun4515 Jun 22, 2022
fad7452
Update arrow/src/compute/kernels/cast.rs
viirya Jun 24, 2022
46d022d
Update arrow/src/compute/kernels/cast.rs
viirya Jun 24, 2022
3a7344a
Merge branch 'support_NULL_to_decimal' of github.com:liukun4515/arrow…
liukun4515 Jun 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
36 changes: 29 additions & 7 deletions arrow/src/compute/kernels/cast.rs
View file
Open in desktop
Expand Up @@ -72,9 +72,9 @@ pub fn can_cast_types(from_type: &DataType, to_type: &DataType) -> bool {
// cast one decimal type to another decimal type
(Decimal(_, _), Decimal(_, _)) => true,
// signed numeric to decimal
(Int8 | Int16 | Int32 | Int64 | Float32 | Float64, Decimal(_, _)) |
(Null | Int8 | Int16 | Int32 | Int64 | Float32 | Float64, Decimal(_, _)) |
// decimal to signed numeric
(Decimal(_, _), Int8 | Int16 | Int32 | Int64 | Float32 | Float64)
(Decimal(_, _), Null | Int8 | Int16 | Int32 | Int64 | Float32 | Float64)
| (
Null,
Boolean
Expand Down Expand Up @@ -251,21 +251,21 @@ pub fn can_cast_types(from_type: &DataType, to_type: &DataType) -> bool {
(Int64, Duration(_)) => true,
(Duration(_), Int64) => true,
(Interval(from_type), Int64) => {
match from_type{
match from_type {
IntervalUnit::YearMonth => true,
IntervalUnit::DayTime => true,
IntervalUnit::MonthDayNano => false, // Native type is i128
}
},
}
(Int32, Interval(to_type)) => {
match to_type{
match to_type {
IntervalUnit::YearMonth => true,
IntervalUnit::DayTime => false,
IntervalUnit::MonthDayNano => false,
}
},
}
(Int64, Interval(to_type)) => {
match to_type{
match to_type {
IntervalUnit::YearMonth => false,
IntervalUnit::DayTime => true,
IntervalUnit::MonthDayNano => false,
Expand Down Expand Up @@ -447,6 +447,7 @@ pub fn cast_with_options(
Float64 => {
cast_decimal_to_float!(array, scale, Float64Builder, f64)
}
Null => Ok(new_null_array(to_type, array.len())),
_ => Err(ArrowError::CastError(format!(
"Casting from {:?} to {:?} not supported",
from_type, to_type
Expand Down Expand Up @@ -475,6 +476,7 @@ pub fn cast_with_options(
Float64 => {
cast_floating_point_to_decimal!(array, Float64Array, precision, scale)
}
Null => Ok(new_null_array(to_type, array.len())),
_ => Err(ArrowError::CastError(format!(
"Casting from {:?} to {:?} not supported",
from_type, to_type
Expand Down Expand Up @@ -4312,6 +4314,26 @@ mod tests {
assert_eq!(array_to_strings(&cast_array), expected);
}

#[test]
fn test_cast_null_array_to_from_decimal_array() {
let data_type = DataType::Decimal(12, 4);
let array = new_null_array(&DataType::Null, 4);
assert_eq!(array.data_type(), &DataType::Null);
let cast_array = cast(&array, &data_type).expect("cast failed");
assert_eq!(cast_array.data_type(), &data_type);
for i in 0..4 {
assert!(cast_array.is_null(i));
}

let array = new_null_array(&data_type, 4);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not support casting Decimal to Null? If we don't add support in this PR can / should file a ticket to add it in a follow on I think

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will fill up Decimal to Null in this pull request.

assert_eq!(array.data_type(), &data_type);
let cast_array = cast(&array, &DataType::Null).expect("cast failed");
assert_eq!(cast_array.data_type(), &DataType::Null);
for i in 0..4 {
assert!(cast_array.is_null(i));
}
}

#[test]
fn test_cast_null_array_from_and_to_primitive_array() {
macro_rules! typed_test {
Expand Down