Fix max and min decimal for max precision #1917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viirya
commented
Jun 20, 2022
| @@ -238,7 +238,7 @@ pub const MAX_DECIMAL_FOR_EACH_PRECISION: [i128; 38] = [ | |||
| 99999999999999999999999999999999999, | |||
| 999999999999999999999999999999999999, | |||
| 9999999999999999999999999999999999999, | |||
| 170141183460469231731687303715884105727, | |||
There was a problem hiding this comment.
This is max value of i128, not max value of decimal of precision 38.
There was a problem hiding this comment.
@viirya
This is a mistake when i create this table and use the max or min of i128.
Codecov Report
@@ Coverage Diff @@
## master #1917 +/- ##
=======================================
Coverage 83.41% 83.42%
=======================================
Files 214 214
Lines 56991 57004 +13
=======================================
+ Hits 47541 47553 +12
- Misses 9450 9451 +1
Continue to review full report at Codecov.
|
liukun4515
approved these changes
Jun 21, 2022
|
Thank you @liukun4515 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1916.
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?