Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use bit_slice in combine_option_bitmap #1900

Merged

Conversation

jhorstmann
Copy link
Contributor

Which issue does this PR close?

Closes #1899.

Rationale for this change

The buffers are storing validity bits and there the offset has to be interpreted as number of bits instead of bytes when slicing.

What changes are included in this PR?

Are there any user-facing changes?

No

@github-actions github-actions bot added the arrow Changes to the arrow crate label Jun 17, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1900 (eaefe40) into master (fc4044f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1900   +/-   ##
=======================================
  Coverage   83.43%   83.43%           
=======================================
  Files         203      203           
  Lines       56969    56993   +24     
=======================================
+ Hits        47531    47553   +22     
- Misses       9438     9440    +2     
Impacted Files Coverage Δ
arrow/src/compute/util.rs 99.10% <100.00%> (+0.10%) ⬆️
parquet_derive/src/parquet_field.rs 65.75% <0.00%> (-0.46%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc4044f...eaefe40. Read the comment docs.

@tustvold
Copy link
Contributor

Integration test failures seem unrelated, so getting this one in.

@tustvold tustvold merged commit c7f89e1 into apache:master Jun 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Final slicing in combine_option_bitmap needs to use bit slices
3 participants