Do not print exit code from miri, instead it should be the return value of the script #1873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
approved these changes
Jun 14, 2022
martin-g
reviewed
Jun 14, 2022
| @@ -15,4 +15,3 @@ cargo clean | |||
|
|
|||
| echo "Starting Arrow MIRI run..." | |||
| cargo miri test -p arrow -- --skip csv --skip ipc --skip json | |||
There was a problem hiding this comment.
You could use something like:
cargo miri test -p arrow -- --skip csv --skip ipc --skip json
MIRI_RETURN_CODE=$?
echo "Miri finished with exit code $MIRI_RETURN_CODE"
exit $MIRI_RETURN_CODEThere was a problem hiding this comment.
Thanks, that would work. I now realized that the status is already printed:
Error: Process completed with exit code 1.
viirya
approved these changes
Jun 14, 2022
|
I think this just needs a rebase and then it can go in? |
jhorstmann
force-pushed
the
dont-print-miri-exit-code
branch
from
02bfbbf
to
1c0eef1
Compare
martin-g
approved these changes
Jun 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Small followup to #1863
Related to #1872, I think the leak reported there should have failed the pipeline
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?