Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add two from methods for FixedSizeBinaryArray #1854

Merged
merged 3 commits into from Jun 13, 2022

Conversation

HaoYang670
Copy link
Contributor

Signed-off-by: remzi 13716567376yh@gmail.com

Which issue does this PR close?

Closes #1852.

Rationale for this change

Users can easily build FixedSizeBinaryArray from vectors.

What changes are included in this PR?

From<Vec<Option<&[u8]>>> for FixedSizeBinaryArray
From<Vec<&[u8]>> for FixedSizeBinaryArray

Are there any user-facing changes?

Yes. new APIs.

Signed-off-by: remzi <13716567376yh@gmail.com>
@github-actions github-actions bot added the arrow Changes to the arrow crate label Jun 13, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jun 13, 2022

Codecov Report

Merging #1854 (27b4dd9) into master (c08e532) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1854      +/-   ##
==========================================
+ Coverage   83.49%   83.52%   +0.02%     
==========================================
  Files         201      201              
  Lines       56903    56948      +45     
==========================================
+ Hits        47511    47563      +52     
+ Misses       9392     9385       -7     
Impacted Files Coverage Δ
arrow/src/array/array_binary.rs 94.24% <100.00%> (+0.92%) ⬆️
arrow/src/buffer/ops.rs 96.77% <0.00%> (ø)
parquet/src/arrow/mod.rs 44.44% <0.00%> (ø)
parquet/src/arrow/levels.rs
...arquet/src/arrow/array_reader/dictionary_buffer.rs
parquet/src/arrow/converter.rs
parquet/src/arrow/record_reader.rs
parquet/src/arrow/bit_util.rs
parquet/src/arrow/array_reader/offset_buffer.rs
parquet/src/arrow/arrow_writer.rs
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c08e532...27b4dd9. Read the comment docs.

Signed-off-by: remzi <13716567376yh@gmail.com>
@HaoYang670 HaoYang670 marked this pull request as draft June 13, 2022 02:35
Signed-off-by: remzi <13716567376yh@gmail.com>
@HaoYang670 HaoYang670 marked this pull request as ready for review June 13, 2022 02:59
@tustvold tustvold merged commit 6144f19 into apache:master Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add from(v: Vec<Option<&[u8]>>) and from(v: Vec<&[u8]>) for FixedSizedBInaryArray
3 participants