Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Further seal the OffsetSizeTrait #1823

Closed
wants to merge 3 commits into from
Closed

Further seal the OffsetSizeTrait #1823

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
79c3196
seal OffsetSizeTrait
HaoYang670 Jun 9, 2022
46a353e
fix nit in docs
HaoYang670 Jun 9, 2022
93677f9
delete useless file
HaoYang670 Jun 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
14 changes: 12 additions & 2 deletions arrow/src/array/array_list.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,11 @@ use crate::{
error::ArrowError,
};

/// trait declaring an offset size, relevant for i32 vs i64 array types.
pub trait OffsetSizeTrait: ArrowNativeType + std::ops::AddAssign + Integer {
/// [`OffsetSizeTrait`] describes types that can be used as offsets.
/// This trait is sealed and cannot be implemented for types except [`i32`] and [`i64`].
pub trait OffsetSizeTrait:
ArrowNativeType + std::ops::AddAssign + Integer + private::Sealed
{
const IS_LARGE: bool;
}

Expand All @@ -43,6 +46,13 @@ impl OffsetSizeTrait for i64 {
const IS_LARGE: bool = true;
}

mod private {
/// Prevent users from implementing the [`super::OffsetSizeTrait`].
pub trait Sealed {}
impl Sealed for i32 {}
impl Sealed for i64 {}
}

/// Generic struct for a variable-size list array.
///
/// Columnar format in Apache Arrow:
Expand Down