Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use IPC row count info in IPC reader #1796

Merged
merged 3 commits into from Jun 6, 2022
Merged

Conversation

viirya
Copy link
Member

@viirya viirya commented Jun 5, 2022

Which issue does this PR close?

Closes #1783.

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added the arrow Changes to the arrow crate label Jun 5, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1796 (6b6f148) into master (73d552a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1796   +/-   ##
=======================================
  Coverage   83.39%   83.39%           
=======================================
  Files         198      198           
  Lines       56205    56213    +8     
=======================================
+ Hits        46872    46881    +9     
+ Misses       9333     9332    -1     
Impacted Files Coverage Δ
arrow/src/ipc/reader.rs 90.82% <100.00%> (+0.08%) ⬆️
parquet_derive/src/parquet_field.rs 65.75% <0.00%> (-0.23%) ⬇️
parquet/src/encodings/encoding.rs 93.46% <0.00%> (-0.20%) ⬇️
arrow/src/ipc/gen/Message.rs 35.39% <0.00%> (+0.74%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73d552a...6b6f148. Read the comment docs.

arrow/src/ipc/reader.rs Outdated Show resolved Hide resolved
Co-authored-by: Raphael Taylor-Davies <1781103+tustvold@users.noreply.github.com>
@viirya viirya merged commit b5fbd11 into apache:master Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flight_data_to_arrow_batch does not support RecordBatches with no columns
3 participants