Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arbitrary size concat elements utf8 #1787

Merged
merged 15 commits into from Jun 29, 2022

Conversation

ismailmaj
Copy link
Contributor

Which issue does this PR close?

Closes #1748.

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

Should be merged after #1780.

@github-actions github-actions bot added the arrow Changes to the arrow crate label Jun 4, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jun 4, 2022

Codecov Report

Merging #1787 (759d4b5) into master (9e8c1bf) will increase coverage by 0.00%.
The diff coverage is 98.11%.

@@           Coverage Diff           @@
##           master    #1787   +/-   ##
=======================================
  Coverage   83.47%   83.48%           
=======================================
  Files         221      221           
  Lines       57042    57094   +52     
=======================================
+ Hits        47616    47665   +49     
- Misses       9426     9429    +3     
Impacted Files Coverage Δ
arrow/src/compute/kernels/concat_elements.rs 99.17% <98.11%> (-0.83%) ⬇️
arrow/src/datatypes/datatype.rs 65.42% <0.00%> (-0.38%) ⬇️
parquet_derive/src/parquet_field.rs 65.75% <0.00%> (-0.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e8c1bf...759d4b5. Read the comment docs.

@ismailmaj ismailmaj marked this pull request as ready for review June 8, 2022 18:58
Copy link
Contributor

@tustvold tustvold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would be very interested to see some benchmarks of this, this has introduced a number of additional memory allocations and a significantly more complicated loop body, it may not matter, but it would be good to verify either way...

arrow/src/compute/kernels/concat_elements.rs Show resolved Hide resolved
@ismailmaj
Copy link
Contributor Author

Thank you for the review @tustvold!
I'll work on a benchmark, I'm wondering if we could use smallvec to avoid heap allocating with only a few arrays as input.

@alamb
Copy link
Contributor

alamb commented Jun 16, 2022

FYI I think @tustvold is out this week

Another way to move this PR forward might be to make this a new kernel (rather than modifying the existing concat_elements_utf8), perhaps something like concat_n_elements_utf8 or concat_elements_utf8_many?

That way we aren't worried about a potential regression in performance and people can optimize the new kernel in the future if that is desired

@HaoYang670
Copy link
Contributor

I'll work on a benchmark.

@Ismail-Maj This could be done as a follow-up PR.

@ismailmaj ismailmaj requested a review from tustvold June 24, 2022 11:21
Copy link
Contributor

@tustvold tustvold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, thank you 👍

@tustvold tustvold merged commit e81f93b into apache:master Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

concat_elements_utf8 should accept arbitrary number of input arrays
5 participants