New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FixedSizeBinaryArray::try_from_sparse_iter failed when given all Nones #1508
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1508 +/- ##
==========================================
- Coverage 82.73% 82.73% -0.01%
==========================================
Files 188 188
Lines 54354 54356 +2
==========================================
- Hits 44970 44969 -1
- Misses 9384 9387 +3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix. Can you also add a test for the fix?
I agree we should have a test prior to merging. Thanks @jamescorbett |
We can probably just copy the test from #1390 |
I will do sorry I have had work commitments. |
No worries -- sorry I didn't mean to pressure you. Thank you for the contribution; I can add the tests too if you don't have time |
Marking as a draft to signify there is still some work to do. Please feel free to mark it ready for review when it is |
Closing this as #3054 has added support for this |
Which issue does this PR close?
Closes ##1390.
Rationale for this change
Minimally invasive change to work around Options being unsized if None.
What changes are included in this PR?
Adding new function to get access to default size while maintaining original functionality.
Are there any user-facing changes?
One additional function
try_from_sparse_iter_sized