Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove out of date comment #1008

Merged
merged 1 commit into from Dec 6, 2021
Merged

Remove out of date comment #1008

merged 1 commit into from Dec 6, 2021

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Dec 4, 2021

re #996

@jhorstmann points out that bool no longer implements ArrowNativeType and thus this comment it out of date. Remove it

Here are the types that implement ArrowNativeType

/Users/alamb/Software/arrow-rs/arrow/src/datatypes/native.rs
118: impl ArrowNativeType for i8 {
141: impl ArrowNativeType for i16 {
164: impl ArrowNativeType for i32 {
193: impl ArrowNativeType for i64 {
222: impl ArrowNativeType for u8 {
245: impl ArrowNativeType for u16 {
268: impl ArrowNativeType for u32 {
291: impl ArrowNativeType for u64 {
326: impl ArrowNativeType for f16 {}
327: impl ArrowNativeType for f32 {}
328: impl ArrowNativeType for f64 {}

@github-actions github-actions bot added the arrow Changes to the arrow crate label Dec 4, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #1008 (9e6cabd) into master (5806d29) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1008   +/-   ##
=======================================
  Coverage   82.31%   82.31%           
=======================================
  Files         168      168           
  Lines       49031    49031           
=======================================
  Hits        40360    40360           
  Misses       8671     8671           
Impacted Files Coverage Δ
arrow/src/buffer/immutable.rs 97.84% <ø> (ø)
arrow/src/datatypes/field.rs 53.37% <0.00%> (-0.31%) ⬇️
parquet_derive/src/parquet_field.rs 66.21% <0.00%> (+0.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5806d29...9e6cabd. Read the comment docs.

@alamb alamb merged commit 239cba1 into apache:master Dec 6, 2021
@alamb alamb deleted the alamb/comments branch December 6, 2021 20:39
alamb added a commit that referenced this pull request Dec 9, 2021
@alamb alamb added the cherry-picked PR that was backported to active release (will be included in maintenance release) label Dec 9, 2021
alamb added a commit that referenced this pull request Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate cherry-picked PR that was backported to active release (will be included in maintenance release)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants