Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate use of NaiveDateTime in APIs #5480

Open
tustvold opened this issue Mar 6, 2024 · 0 comments · May be fixed by #5684
Open

Deprecate use of NaiveDateTime in APIs #5480

tustvold opened this issue Mar 6, 2024 · 0 comments · May be fixed by #5684
Labels
enhancement Any new improvement worthy of a entry in the changelog help wanted

Comments

@tustvold
Copy link
Contributor

tustvold commented Mar 6, 2024

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

NaiveDateTime is hard to use correctly, and it is very easy to introduce subtle bugs.

https://github.com/chronotope/chrono/releases/tag/v0.4.35 deprecated a large number of methods on NaiveDateTime for this reason, we should follow their example

Describe the solution you'd like

I would like to alter these methods to return DateTime<Utc>

Describe alternatives you've considered

Additional context
@tustvold tustvold added the enhancement Any new improvement worthy of a entry in the changelog label Mar 6, 2024
@tustvold tustvold mentioned this issue Mar 6, 2024
Merged
@Michael-J-Ward Michael-J-Ward linked a pull request Apr 24, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Any new improvement worthy of a entry in the changelog help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Deprecate NaiveDateTime Michael-J-Ward/arrow-rs
1 participant
@tustvold