Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid results with RowSelector having row_count of 0 #2669

Closed
thinkharderdev opened this issue Sep 6, 2022 · 0 comments · Fixed by #2678
Closed

Invalid results with RowSelector having row_count of 0 #2669

thinkharderdev opened this issue Sep 6, 2022 · 0 comments · Fixed by #2678
Labels
bug parquet Changes to the parquet crate

Comments

@thinkharderdev
Copy link
Contributor

Describe the bug

See the discussion here #2656 (comment).

In test_fuzz_async_reader_selection if we generate RowSelectors with 0 rows then we get invalid results from ParquetRecordBatchSream.

To Reproduce

Expected behavior

We should handle (effectively ignore) RowSelectors with row_count == 0 without issues.

Additional context
@askoa askoa mentioned this issue Sep 7, 2022
Merged
@tustvold tustvold added the parquet Changes to the parquet crate label Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug parquet Changes to the parquet crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Skip RowSelectors with zero rows
2 participants
@thinkharderdev @tustvold