Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use http:// in GCS integration test instead of insecure TLS #2632

Merged
merged 1 commit into from Sep 2, 2022
Merged

Use http:// in GCS integration test instead of insecure TLS #2632

merged 1 commit into from Sep 2, 2022

Conversation

tustvold
Copy link
Contributor

@tustvold tustvold commented Sep 2, 2022

Which issue does this PR close?

Closes #.

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added the object-store Object Store Interface label Sep 2, 2022
@tustvold tustvold added the development-process Related to development process of arrow-rs label Sep 2, 2022
@tustvold tustvold force-pushed the gcs-http branch 2 times, most recently from 9a604c3 to c1ba241 Compare September 2, 2022 06:05
tustvold
tustvold commented Sep 2, 2022
View reviewed changes
.github/workflows/object_store.yml
@@ -116,18 +97,16 @@ jobs:
AWS_SECRET_ACCESS_KEY: test
AWS_ENDPOINT: http://localstack:4566
run: |
cd /tmp
curl "https://awscli.amazonaws.com/awscli-exe-linux-x86_64.zip" -o "awscliv2.zip"
Copy link
Contributor Author

@tustvold tustvold Sep 2, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A happy side-effect of switching to not using the docker runner is the AWS and Azure CLI's are automatically installed (along with Rust) - https://github.com/actions/runner-images/blob/main/images/linux/Ubuntu2204-Readme.md#cli-tools

tustvold
tustvold commented Sep 2, 2022
View reviewed changes
.github/workflows/object_store.yml
@@ -60,54 +60,35 @@ jobs:
run: cargo clippy -p object_store --all-features --all-targets -- -D warnings

# test the crate
# This runs outside a container to workaround lack of support for passing arguments
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really tried to avoid this, but I could not find a way around this. We use non-docker runners in other workflows, e.g. miri, integration, coverage, so I think this is probably fine

@tustvold tustvold force-pushed the gcs-http branch 3 times, most recently from 9382e7f to 1262d9d Compare September 2, 2022 06:24
@tustvold tustvold marked this pull request as ready for review September 2, 2022 06:38
@tustvold tustvold mentioned this pull request Sep 2, 2022
Closed
@tustvold tustvold changed the title Use http with fake-gcs Use http:// in GCS integration test instead of insecure TLS Sep 2, 2022
roeap
roeap approved these changes Sep 2, 2022
View reviewed changes
Copy link
Contributor

@roeap roeap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, somehow I was expecting there to be a with_allow_http option on the builder, but CI seems to work without 😆.

@tustvold tustvold merged commit 2d3a350 into apache:master Sep 2, 2022
@ursabot
Copy link

ursabot commented Sep 2, 2022

Benchmark runs are scheduled for baseline = a9875f5 and contender = 2d3a350. 2d3a350 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roeap roeap roeap approved these changes

Assignees
No one assigned
Labels
development-process Related to development process of arrow-rs object-store Object Store Interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tustvold @ursabot @roeap