Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify FixedSizeBinaryBuilder #2007

Closed
HaoYang670 opened this issue Jul 6, 2022 · 0 comments · Fixed by #2013
Closed

Simplify FixedSizeBinaryBuilder #2007

HaoYang670 opened this issue Jul 6, 2022 · 0 comments · Fixed by #2013
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog

Comments

@HaoYang670
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
Currently, the FixedSizeBinaryBuilder is built on FixedSizeListBuilder, which introduce some extra computation(create child array, cast from listarray to binary array). We could simplily it by just using 2 buffer builders (not tested):

pub struct FixedSizeBinaryBuilder {
    values_builder: BufferBuilder<UInt8Type>,
    bitmap_builder: BooleanBufferBuilder,
    value_length: i32,
}

This may introduce just a little more code, but could save some amount of computation.

Describe alternatives you've considered
We could not do this.

Additional context
Add any other context or screenshots about the feature request here.

@HaoYang670 HaoYang670 added the enhancement Any new improvement worthy of a entry in the changelog label Jul 6, 2022
@alamb alamb added the arrow Changes to the arrow crate label Jul 7, 2022
@alamb alamb changed the title Simplify the FixedSizeBinaryBuilder Simplify FixedSizeBinaryBuilder Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants