Don't generate empty google.protobuf.rs #2005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ted-Jiang
approved these changes
Jul 6, 2022
alamb
reviewed
Jul 8, 2022
| @@ -88,6 +88,13 @@ fn main() -> Result<(), Box<dyn std::error::Error>> { | |||
| file.write_all(buffer.as_bytes())?; | |||
| } | |||
|
|
|||
| // Prost currently generates an empty file, this was fixed but then reverted | |||
| // https://github.com/tokio-rs/prost/pull/639 | |||
| let google_protobuf_rs = Path::new("src/sql/google.protobuf.rs"); | |||
There was a problem hiding this comment.
should we also test that it is actually empty?
There was a problem hiding this comment.
We could do, but given it would be a code change to actually include!() it in the source code, I'm inclined to think it doesn't matter
There was a problem hiding this comment.
I was thinking something like https://doc.rust-lang.org/stable/std/fs/struct.Metadata.html#method.len
I was worrying about some poor soul in the future who expects the file to be there (because maybe some new version of prost puts something useful in it) but it is mysteriously deleted
alamb
approved these changes
Jul 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
Since tokio-rs/prost#639 was reverted, prost generates some empty files. Lets explicitly make sure this file is expunged.
What changes are included in this PR?
Automatically deletes the empty file if it is created
Are there any user-facing changes?
No