Update to latest Clippy (#3832)

* Renamed clippy lint * More clippy * Even more clippy * Clippy
apache · Mar 9, 2023 · de9f826 · de9f826
1 parent fb35d26
commit de9f826
Show file tree

Hide file tree

Showing 7 changed files with 11 additions and 17 deletions.
diff --git a/arrow-arith/src/arithmetic.rs b/arrow-arith/src/arithmetic.rs
@@ -2571,9 +2571,9 @@ mod tests {
 
     #[test]
     fn test_primitive_array_negate() {
-        let a: Int64Array = (0..100).into_iter().map(Some).collect();
+        let a: Int64Array = (0..100).map(Some).collect();
         let actual = negate(&a).unwrap();
-        let expected: Int64Array = (0..100).into_iter().map(|i| Some(-i)).collect();
+        let expected: Int64Array = (0..100).map(|i| Some(-i)).collect();
         assert_eq!(expected, actual);
     }
 
@@ -2590,20 +2590,18 @@ mod tests {
 
     #[test]
     fn test_arithmetic_kernel_should_not_rely_on_padding() {
-        let a: UInt8Array = (0..128_u8).into_iter().map(Some).collect();
+        let a: UInt8Array = (0..128_u8).map(Some).collect();
         let a = a.slice(63, 65);
         let a = a.as_any().downcast_ref::<UInt8Array>().unwrap();
 
-        let b: UInt8Array = (0..128_u8).into_iter().map(Some).collect();
+        let b: UInt8Array = (0..128_u8).map(Some).collect();
         let b = b.slice(63, 65);
         let b = b.as_any().downcast_ref::<UInt8Array>().unwrap();
 
         let actual = add(a, b).unwrap();
         let actual: Vec<Option<u8>> = actual.iter().collect();
-        let expected: Vec<Option<u8>> = (63..63_u8 + 65_u8)
-            .into_iter()
-            .map(|i| Some(i + i))
-            .collect();
+        let expected: Vec<Option<u8>> =
+            (63..63_u8 + 65_u8).map(|i| Some(i + i)).collect();
         assert_eq!(expected, actual);
     }
 

diff --git a/arrow-schema/src/schema.rs b/arrow-schema/src/schema.rs
@@ -264,7 +264,7 @@ impl fmt::Display for Schema {
 }
 
 // need to implement `Hash` manually because `HashMap` implement Eq but no `Hash`
-#[allow(clippy::derive_hash_xor_eq)]
+#[allow(clippy::derived_hash_with_manual_eq)]
 impl Hash for Schema {
     fn hash<H: std::hash::Hasher>(&self, state: &mut H) {
         self.fields.hash(state);

diff --git a/arrow/benches/boolean_append_packed.rs b/arrow/benches/boolean_append_packed.rs
@@ -30,7 +30,6 @@ fn boolean_append_packed(c: &mut Criterion) {
     let mut rng = thread_rng();
     let source = rand_bytes(1024);
     let ranges: Vec<_> = (0..100)
-        .into_iter()
         .map(|_| {
             let start: usize = rng.gen_range(0..1024 * 8);
             let end: usize = rng.gen_range(start..1024 * 8);

diff --git a/arrow/src/array/ffi.rs b/arrow/src/array/ffi.rs
@@ -215,7 +215,7 @@ mod tests {
 
     #[test]
     fn test_fixed_size_list() -> Result<()> {
-        let v: Vec<i64> = (0..9).into_iter().collect();
+        let v: Vec<i64> = (0..9).collect();
         let value_data = ArrayData::builder(DataType::Int64)
             .len(9)
             .add_buffer(Buffer::from_slice_ref(v))
@@ -240,7 +240,7 @@ mod tests {
         bit_util::set_bit(&mut validity_bits, 2);
         bit_util::set_bit(&mut validity_bits, 6);
 
-        let v: Vec<i16> = (0..16).into_iter().collect();
+        let v: Vec<i16> = (0..16).collect();
         let value_data = ArrayData::builder(DataType::Int16)
             .len(16)
             .add_buffer(Buffer::from_slice_ref(v))
@@ -260,7 +260,7 @@ mod tests {
 
     #[test]
     fn test_fixed_size_list_nested() -> Result<()> {
-        let v: Vec<i32> = (0..16).into_iter().collect();
+        let v: Vec<i32> = (0..16).collect();
         let value_data = ArrayData::builder(DataType::Int32)
             .len(16)
             .add_buffer(Buffer::from_slice_ref(v))

diff --git a/arrow/src/ffi.rs b/arrow/src/ffi.rs
@@ -957,7 +957,7 @@ mod tests {
         let mut validity_bits: [u8; 1] = [0; 1];
         bit_util::set_bit(&mut validity_bits, 2);
 
-        let v: Vec<i32> = (0..9).into_iter().collect();
+        let v: Vec<i32> = (0..9).collect();
         let value_data = ArrayData::builder(DataType::Int32)
             .len(9)
             .add_buffer(Buffer::from_slice_ref(&v))

diff --git a/arrow/tests/array_cast.rs b/arrow/tests/array_cast.rs
@@ -428,7 +428,6 @@ fn get_all_types() -> Vec<DataType> {
                 Dictionary(Box::new(key_type), Box::new(Decimal256(76, 0))),
             ]
         })
-        .into_iter()
         .collect::<Vec<_>>();
 
     types.append(&mut dictionary_types);

diff --git a/parquet/src/arrow/async_reader/mod.rs b/parquet/src/arrow/async_reader/mod.rs
@@ -622,7 +622,6 @@ impl<'a> InMemoryRowGroup<'a> {
                 .iter()
                 .zip(self.metadata.columns())
                 .enumerate()
-                .into_iter()
                 .filter_map(|(idx, (chunk, chunk_meta))| {
                     (chunk.is_none() && projection.leaf_included(idx)).then(|| {
                         // If the first page does not start at the beginning of the column,
@@ -671,7 +670,6 @@ impl<'a> InMemoryRowGroup<'a> {
                 .column_chunks
                 .iter()
                 .enumerate()
-                .into_iter()
                 .filter_map(|(idx, chunk)| {
                     (chunk.is_none() && projection.leaf_included(idx)).then(|| {
                         let column = self.metadata.column(idx);