Skip to content

Commit

Permalink
More record skipping fuzz tests (#2505)
Browse files Browse the repository at this point in the history
  • Loading branch information
tustvold committed Aug 20, 2022
1 parent 7cfe3cf commit cbaa2c0
Showing 1 changed file with 9 additions and 3 deletions.
12 changes: 9 additions & 3 deletions parquet/src/arrow/arrow_reader/mod.rs
Expand Up @@ -605,7 +605,6 @@ pub(crate) fn evaluate_predicate(

#[cfg(test)]
mod tests {
use bytes::Bytes;
use std::cmp::min;
use std::collections::VecDeque;
use std::fmt::Formatter;
Expand All @@ -614,6 +613,7 @@ mod tests {
use std::path::PathBuf;
use std::sync::Arc;

use bytes::Bytes;
use rand::{thread_rng, Rng, RngCore};
use tempfile::tempfile;

Expand Down Expand Up @@ -1299,12 +1299,19 @@ mod tests {
// Test with nulls and row filter
TestOptions::new(2, 256, 93)
.with_null_percent(25)
.with_max_data_page_size(10)
.with_row_filter(),
// Test with nulls and row filter
// Test with nulls and row filter and small pages
TestOptions::new(2, 256, 93)
.with_null_percent(25)
.with_max_data_page_size(10)
.with_row_selections()
.with_row_filter(),
// Test with row selection and no offset index and small pages
TestOptions::new(2, 256, 93)
.with_enabled_statistics(EnabledStatistics::None)
.with_max_data_page_size(10)
.with_row_selections(),
];

all_options.into_iter().for_each(|opts| {
Expand Down Expand Up @@ -1417,7 +1424,6 @@ mod tests {

file.rewind().unwrap();

// TODO: Should be able to always enable page index (#2434)
let options = ArrowReaderOptions::new()
.with_page_index(opts.enabled_statistics == EnabledStatistics::Page);

Expand Down

0 comments on commit cbaa2c0

Please sign in to comment.