Cleanup cast kernel (#2846)

* Cleanup cast kernel * Fix timezone handling
apache · Oct 8, 2022 · 9db7518 · 9db7518
1 parent 5cf46d4
commit 9db7518
Show file tree

Hide file tree

Showing 2 changed files with 261 additions and 327 deletions.
diff --git a/arrow-array/src/array/primitive_array.rs b/arrow-array/src/array/primitive_array.rs
@@ -769,11 +769,16 @@ impl<T: ArrowTimestampType> PrimitiveArray<T> {
 
     /// Construct a timestamp array with new timezone
     pub fn with_timezone(&self, timezone: String) -> Self {
+        self.with_timezone_opt(Some(timezone))
+    }
+
+    /// Construct a timestamp array with an optional timezone
+    pub fn with_timezone_opt(&self, timezone: Option<String>) -> Self {
         let array_data = unsafe {
             self.data
                 .clone()
                 .into_builder()
-                .data_type(DataType::Timestamp(T::get_time_unit(), Some(timezone)))
+                .data_type(DataType::Timestamp(T::get_time_unit(), timezone))
                 .build_unchecked()
         };
         PrimitiveArray::from(array_data)