Skip to content

Commit

Permalink
Remove sliceable cursor (#2378)
Browse files Browse the repository at this point in the history
  • Loading branch information
tustvold committed Aug 8, 2022
1 parent 3264d7d commit 613b99d
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 303 deletions.
19 changes: 1 addition & 18 deletions parquet/src/file/serialized_reader.rs
Expand Up @@ -39,8 +39,7 @@ use crate::util::{io::TryClone, memory::ByteBufferPtr};

// export `SliceableCursor` and `FileSource` publically so clients can
// re-use the logic in their own ParquetFileWriter wrappers
#[allow(deprecated)]
pub use crate::util::{cursor::SliceableCursor, io::FileSource};
pub use crate::util::io::FileSource;

// ----------------------------------------------------------------------
// Implementations of traits facilitating the creation of a new reader
Expand Down Expand Up @@ -86,22 +85,6 @@ impl ChunkReader for Bytes {
}
}

#[allow(deprecated)]
impl Length for SliceableCursor {
fn len(&self) -> u64 {
SliceableCursor::len(self)
}
}

#[allow(deprecated)]
impl ChunkReader for SliceableCursor {
type T = SliceableCursor;

fn get_read(&self, start: u64, length: usize) -> Result<Self::T> {
self.slice(start, length).map_err(|e| e.into())
}
}

impl TryFrom<File> for SerializedFileReader<File> {
type Error = ParquetError;

Expand Down
284 changes: 0 additions & 284 deletions parquet/src/util/cursor.rs

This file was deleted.

1 change: 0 additions & 1 deletion parquet/src/util/mod.rs
Expand Up @@ -20,7 +20,6 @@ pub mod memory;
#[macro_use]
pub mod bit_util;
mod bit_pack;
pub mod cursor;
pub(crate) mod interner;
pub(crate) mod page_util;
#[cfg(any(test, feature = "test_common"))]
Expand Down

0 comments on commit 613b99d

Please sign in to comment.