Skip to content

Commit

Permalink
Fix multipart uploads on Minio (#2731)
Browse files Browse the repository at this point in the history
The official Minio SDK uses "uploads=" as the URL when it initiates a
multipart upload instead of "uploads". This affects the AWSV4 signature
and causes object_store to fail a signature check when initiating the
upload to Minio.

It's possible that this contradicts the AWS S3 API docs:
https://docs.aws.amazon.com/AmazonS3/latest/API/API_CreateMultipartUpload.html#API_CreateMultipartUpload_RequestSyntax
and we need to instead keep the URL as `?uploads` and
change the URL that goes into the signature instead.
  • Loading branch information
mildbyte committed Sep 15, 2022
1 parent fb01656 commit 5f441ee
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion object_store/src/aws/client.rs
Expand Up @@ -411,7 +411,7 @@ impl S3Client {
pub async fn create_multipart(&self, location: &Path) -> Result<MultipartId> {
let credential = self.get_credential().await?;
let url = format!(
"{}/{}/{}?uploads",
"{}/{}/{}?uploads=",
self.config.endpoint,
self.config.bucket,
encode_path(location)
Expand Down

0 comments on commit 5f441ee

Please sign in to comment.