Skip to content

Commit

Permalink
Update divide doc with dividing by zero behavior for other numeric ty…
Browse files Browse the repository at this point in the history
…pes.
  • Loading branch information
viirya committed Sep 4, 2022
1 parent 4aa4432 commit 3d98aff
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion arrow/src/compute/kernels/arithmetic.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1201,7 +1201,8 @@ pub fn divide_dyn(left: &dyn Array, right: &dyn Array) -> Result<ArrayRef> {
}

/// Perform `left / right` operation on two arrays without checking for division by zero.
/// The result of dividing by zero follows normal floating point rules.
/// For floating point types, the result of dividing by zero follows normal floating point
/// rules. For other numeric types, dividing by zero will panic,
/// If either left or right value is null then the result is also null. If any right hand value is zero then the result of this
///
/// This doesn't detect overflow. Once overflowing, the result will wrap around.
Expand Down

0 comments on commit 3d98aff

Please sign in to comment.