Skip to content

Commit

Permalink
Update MIRI for split crates (#2594) (#3754)
Browse files Browse the repository at this point in the history
  • Loading branch information
tustvold committed Feb 23, 2023
1 parent 57f79c0 commit 3508674
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 2 deletions.
5 changes: 4 additions & 1 deletion .github/workflows/miri.sh
Expand Up @@ -14,4 +14,7 @@ cargo miri setup
cargo clean

echo "Starting Arrow MIRI run..."
cargo miri test -p arrow -- --skip csv --skip ipc --skip json
cargo miri test -p arrow-buffer
cargo miri test -p arrow-data --features ffi
cargo miri test -p arrow-schema --features ffi
cargo miri test -p arrow-array
1 change: 1 addition & 0 deletions arrow-array/src/array/boolean_array.rs
Expand Up @@ -542,6 +542,7 @@ mod tests {
}

#[test]
#[cfg_attr(miri, ignore)] // Takes too long
fn test_true_false_count() {
let mut rng = thread_rng();

Expand Down
2 changes: 2 additions & 0 deletions arrow-array/src/array/run_array.rs
Expand Up @@ -881,6 +881,7 @@ mod tests {
}

#[test]
#[cfg_attr(miri, ignore)] // Takes too long
fn test_get_physical_indices() {
// Test for logical lengths starting from 10 to 250 increasing by 10
for logical_len in (0..250).step_by(10) {
Expand Down Expand Up @@ -917,6 +918,7 @@ mod tests {
}

#[test]
#[cfg_attr(miri, ignore)] // Takes too long
fn test_get_physical_indices_sliced() {
let total_len = 80;
let input_array = build_input_array(total_len);
Expand Down
1 change: 1 addition & 0 deletions arrow-array/src/run_iterator.rs
Expand Up @@ -349,6 +349,7 @@ mod tests {
}

#[test]
#[cfg_attr(miri, ignore)] // Takes too long
fn test_sliced_run_array_iterator() {
let total_len = 80;
let input_array = build_input_array(total_len);
Expand Down
2 changes: 1 addition & 1 deletion arrow-buffer/src/bigint.rs
Expand Up @@ -549,7 +549,7 @@ impl ToPrimitive for i256 {
}
}

#[cfg(test)]
#[cfg(all(test, not(miri)))] // llvm.x86.subborrow.64 not supported by MIRI
mod tests {
use super::*;
use num::{BigInt, FromPrimitive, Signed, ToPrimitive};
Expand Down

0 comments on commit 3508674

Please sign in to comment.