Use total_cmp for floating value ordering and remove nan_ordering flag

apache · Aug 30, 2022 · 2503670 · 2503670
1 parent 171f80b
commit 2503670
Show file tree

Hide file tree

Showing 3 changed files with 127 additions and 705 deletions.
diff --git a/.github/workflows/arrow.yml b/.github/workflows/arrow.yml
@@ -54,9 +54,6 @@ jobs:
       - name: Test --features=force_validate,prettyprint,ipc_compression,ffi,dyn_cmp_dict
         run: |
           cargo test -p arrow --features=force_validate,prettyprint,ipc_compression,ffi,dyn_cmp_dict
-      - name: Test --features=nan_ordering
-        run: |
-          cargo test -p arrow --features "nan_ordering"
       - name: Run examples
         run: |
           # Test arrow examples

diff --git a/arrow/Cargo.toml b/arrow/Cargo.toml
@@ -87,8 +87,6 @@ pyarrow = ["pyo3", "ffi"]
 force_validate = []
 # Enable ffi support
 ffi = []
-# Enable NaN-ordering behavior on comparison kernels
-nan_ordering = []
 # Enable dyn-comparison of dictionary arrays with other arrays
 # Note: this does not impact comparison against scalars
 dyn_cmp_dict = []