remove useless annotation

apache · Jun 30, 2022 · 1eb54b4 · 1eb54b4
1 parent d65234c
commit 1eb54b4
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 6 deletions.
diff --git a/parquet/src/arrow/array_reader/mod.rs b/parquet/src/arrow/array_reader/mod.rs
@@ -96,7 +96,7 @@ pub trait RowGroupCollection {
     fn column_chunks(
         &self,
         i: usize,
-        row_groups_filter_offset_index: Option<&Vec<Vec<FilterOffsetIndex>>>,
+        _row_groups_filter_offset_index: Option<&Vec<Vec<FilterOffsetIndex>>>,
     ) -> Result<Box<dyn PageIterator>>;
 }
 

diff --git a/parquet/src/arrow/arrow_reader.rs b/parquet/src/arrow/arrow_reader.rs
@@ -103,7 +103,7 @@ impl ArrowReaderOptions {
         self
     }
 
-    /// Set `skip_page_offset`, to skip decoding specific pages
+    /// Set `selected_rows`, to skip decoding specific pages
     pub fn with_skip_page_offset(mut self, selected_rows: RowRanges) -> Self {
         self.selected_rows = Some(selected_rows);
         self

diff --git a/parquet/src/arrow/async_reader.rs b/parquet/src/arrow/async_reader.rs
@@ -457,7 +457,7 @@ impl RowGroupCollection for InMemoryRowGroup {
     fn column_chunks(
         &self,
         i: usize,
-        row_groups_filter_offset_index: Option<&Vec<FilterOffsetIndex>>,
+        _row_groups_filter_offset_index: Option<&Vec<Vec<FilterOffsetIndex>>>,
     ) -> Result<Box<dyn PageIterator>> {
         //todo support page level filter
         let page_reader = self.column_chunks[i].as_ref().unwrap().pages();

diff --git a/parquet/src/column/reader.rs b/parquet/src/column/reader.rs
@@ -214,9 +214,6 @@ where
         // Read exhaustively all pages until we read all batch_size values/levels
         // or there are no more values/levels to read.
         while max(values_read, levels_read) < batch_size {
-            //TODO
-            //add filter page
-            // only read page header and set buf,decoder
             if !self.has_next()? {
                 break;
             }