fix: sqa deprecations for airflow providers #39293
Open
+3
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dondaum
commented
Apr 28, 2024
| @@ -1506,14 +1506,15 @@ def add_user( | |||
| user.username = username | |||
| user.email = email | |||
| user.active = True | |||
| self.get_session.add(user) | |||
There was a problem hiding this comment.
This fixes the SQA 2.0 warning however I think we might could / should leave it as it is. SQA 2.0 complains about the User object that is being merged into a Session along the backref cascade. In SQA 2.0 this won't happen. But we add the User object explicit to session so IMO we should be fine without the change.
There was a problem hiding this comment.
As we discussed here we try to fix all warnings. So IMO this change looks good.
dirrao
approved these changes
Apr 29, 2024
dondaum
force-pushed
the
fix/sqa-deprecations-airflow-providers
branch
from
adcf9d4
to
9bab1fd
Compare
mobuchowski
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #28723
fix deprecations for SQLAlchemy 2.0 for Airflow providers.
FAB
SQLAlchemy 2.0 is changing the behavior when an object is being merged into a Session along the backref cascade. The User needs to be present in the session before it is merged with backref cascade for relationship Role.user.
Openlineage
Removed the sqlalchemy_engine completely. First of all in SQLAlchemy 2.0 the ability to associate an Engine with MetaData object is removed, second IMO the sqlalchemy_engine is not used at all in the function. It is passed to MetaData but not used afterwards.
Reported in providers
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.