Partially resolve builtin variable shadowing (A001)
#39278
+162
−144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Taragolis
added
the
changelog:skip
Taragolis
requested review from
potiuk,
ashb,
jedcunningham,
mobuchowski,
eladkal and
o-nikolas
as code owners
boring-cyborg
bot
added
area:dev-tools
area:logging
area:providers
provider:amazon-aws
vincbeck
reviewed
Apr 26, 2024
| @@ -958,7 +958,7 @@ def down(preserve_volumes: bool, cleanup_mypy_cache: bool, project_name: str): | |||
| @option_verbose | |||
| @option_dry_run | |||
| @click.argument("exec_args", nargs=-1, type=click.UNPROCESSED) | |||
| def exec(exec_args: tuple): | |||
| def exec_(exec_args: tuple): | |||
There was a problem hiding this comment.
Overall I like the change! But as a nit: I am not a big fan of just adding a _ as suffix, it feels weird to me. Non blocking though, if others feel it is fine, I am fine
There was a problem hiding this comment.
Sorry for late response, basically its suggestion from PEP8 or pycodestyle or something similar, I do not really remember when it comes from originally
Particular in this case it is not really matter how to named it because there is interface to cli and not intended to be called directly, I just want to keep original name as close as possible to exec which refers to the breeze exec
In the another word I do not have any preferences, so if there is any better naming I could easy rename it
hussein-awala
approved these changes
Apr 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have plenty of the builtins variables/function with the same name as a builtins functions or constants .
This PR rename it into the non production codebase (dev, tests) and ignore into the existed one in core/providers module.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.