ECS Executor: Set tasks to RUNNING state once active #39212
Merged
+97
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tasks were previously being put into QUEUED state after they were active in the ECS executor. This was to store executor state for task adoption but had the side effect of removing them from the list of running task instances (which has other knock-on effects). Instead change tasks into the RUNNING state, and do not remove them from the list of running tasks.
o-nikolas
requested review from
eladkal,
kaxil,
XD-DENG,
ashb,
pierrejeambrun and
hussein-awala
as code owners
boring-cyborg
bot
added
area:Executors-core
syedahsn
approved these changes
Apr 24, 2024
vincbeck
approved these changes
Apr 24, 2024
eladkal
approved these changes
Apr 24, 2024
eladkal
reviewed
Apr 24, 2024
- DebugExecutor: was overriding the change_state method from the base executor, but changing no behaviour, so move to using the base executor implementation - CeleryExecutor: Plumb through the new param so that the signature matches the base executor
vincbeck
reviewed
Apr 24, 2024
vincbeck
approved these changes
Apr 30, 2024
…state This allows task adoption to still work while using a more accurate state for the executor.
There is a task filter earlier in the event processing method that I missed originally
ferruzzi
approved these changes
May 3, 2024
RodrigoGanancia
pushed a commit
to RodrigoGanancia/airflow
that referenced
this pull request
May 10, 2024
Tasks were previously being put into QUEUED state after they were active in the ECS executor. This was to store executor state for task adoption but had the side effect of removing them from the list of running task instances (which has other knock-on effects). Instead, change tasks into the RUNNING state, and do not remove them from the list of running tasks. * Update change_state usage in debug and celery executor - DebugExecutor: was overriding the change_state method from the base executor, but changing no behaviour, so move to using the base executor implementation - CeleryExecutor: Plumb through the new param so that the signature matches the base executor * Call running_state in try/catch for backcompat
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tasks were previously being put into QUEUED state after they were active in the ECS executor. This was to store executor state for task adoption but had the side effect of removing them from the list of running task instances (which has other knock-on effects). Instead change tasks into the RUNNING state, and do not remove them from the list of running tasks.
Also added some test coverage for the new and existing state change functions on the base executor class
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.